User updates RSS feed #6938
User updates RSS feed #6938
Conversation
There was a problem hiding this comment.
Thanks @rascalking! 🌟
There's a minor bug to be fixed and I left of a frontend question for other maintainers.
warehouse/rss/views.py
Outdated
| latest_releases = ( | ||
| request.db.query(Release) | ||
| .join(Project) | ||
| .filter(Project.users.any(username=user.username)) |
There was a problem hiding this comment.
Note that this doesn't mean that this user has made this release, but rather that this user has some role on a project that has made a release.
In #4603 the request is for both:
(I actually want 2 feeds: one for "stuff I did directly" and one for "projects I am a maintainer on that did releases", to account for projects where the actual releases are done by a bot-user, or by a release manager.)
I think it's fine if we're only implementing half of #4603 here, but we might want to think a little more about what we're calling this feed since updates is pretty generic and we might have multiple feeds here eventually.
We also might want to make it more clear on the profile page what this feed is exactly.
There was a problem hiding this comment.
Hrm...maybe call them "My Releases" vs. "My Projects' Releases"?
tests/unit/test_routes.py
Outdated
| @@ -283,6 +283,13 @@ def add_policy(name, filename): | |||
| pretend.call("ses.hook", "/_/ses-hook/", domain=warehouse), | |||
| pretend.call("rss.updates", "/rss/updates.xml", domain=warehouse), | |||
| pretend.call("rss.packages", "/rss/packages.xml", domain=warehouse), | |||
| pretend.call( | |||
| "rss.user_updates", | |||
| "/user/{username}/updates.xml", | |||
|
Okay, I implemented both feeds, named them |
|
Hi @rascalking, can you update the merge conflicts here now that #7013 has been merged? You might also want to make some updates (docs, etc.) to align more with what was merged there. Also, after giving it some thought I think the URLs should be:
|
|
Sorry, I don't think I'm going to be able to finish this. |
This addresses issue #4603.