-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project releases RSS feed #7013
Conversation
Sure, done now: rebased to master and added authors to this feed, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @scop! Just needs a merge conflict resolved.
Done. |
Anything more I can do to get this in? |
@di @yeraydiazdiaz Ping, anything more I can do to get this in? The approval was posted about a month ago already. |
@di @yeraydiazdiaz ping... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only a few small comments.
Also, it would probably be good to add a link to the the RSS feed (with an RSS icon as well) to this link:
Something like:
<h2 class="page-title split-layout">
<span>Release history</span>
<span class="reset-text margin-top">
<a href="/help/#project-release-notifications">Release notifications</a> | <a href="{{ request.route_path('rss.project.releases', name=release.project.normalized_name) }}">RSS Feed <i class="fa fa-rss" aria-hidden="true"></i></a>
</span>
</h2>
Which would look like:
Also, you'll need to run |
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
@scop For future reference, it's possible to batch all suggestions into a single commit: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request |
Co-authored-by: Dustin Ingram <[email protected]>
Yes, I noticed that option and would have definitely used it. However the button stayed disabled and grayed out so I couldn't. |
Applied suggestions here, thanks. I trust you'll squash/tidy up the history on eventual merge :) It's been so long since I've touched this project that I'll need to go and refresh my memory how I can actually run it to test these, and will take a look at the translations and possible other CI business then. |
I think you have to switch to the "Files changed" view to get that to work, kinda weird. |
@scop I'll save you the trouble 🙂 |
Thanks! I see the actual feeds and help content are live, however the page content changes are not (to me at least): the |
@scop Yes, they will slowly appear as the pages fall out of the cache and get re-rendered. |
Closes #1683
Once #7012 is in, this implementation should be amended with authors in items as well.(it's in now)