Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix teardown error reporting when --maxfail=1 (#11721)" #12022

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

bluetech
Copy link
Member

Fix #12021.
Reopens #11706.

This reverts commit 12b9bd5.

This change caused a bad regression in pytest-xdist: pytest-dev/pytest-xdist#1024

pytest-xdist necessarily has special handling of --maxfail and session fixture teardown get executed multiple times with the change.

Since I'm not sure how to adapt pytest-xdist myself, revert for now.

I kept the sticky shouldstop/shouldfail changes as they are good ideas regardless I think.

…1721)"

Fix pytest-dev#12021.
Reopens pytest-dev#11706.

This reverts commit 12b9bd5.

This change caused a bad regression in pytest-xdist:
pytest-dev/pytest-xdist#1024

pytest-xdist necessarily has special handling of `--maxfail` and session
fixture teardown get executed multiple times with the change.

Since I'm not sure how to adapt pytest-xdist myself, revert for now.

I kept the sticky `shouldstop`/`shouldfail` changes as they are good
ideas regardless I think.
@bluetech bluetech added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Feb 23, 2024
@bluetech
Copy link
Member Author

@bbrown1867 FYI

@bluetech bluetech merged commit 93cd7ba into pytest-dev:main Feb 23, 2024
25 checks passed
@bluetech bluetech deleted the revert-11721 branch February 23, 2024 13:50
bluetech pushed a commit that referenced this pull request May 2, 2024
…2279)

Closes #11706.

Originally fixed in #11721, but then reverted in #12022 due to a regression in pytest-xdist.

The regression was fixed on the pytest-xdist side in pytest-dev/pytest-xdist#1026.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest 8.0.0 --maxfail fix caused a regression in pytest-xdist
2 participants