Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix teardown error reporting when --maxfail=1 (#11721)" #12022

Merged
merged 1 commit into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. Revert "Fix teardown error reporting when --maxfail=1 (pytest-dev#1…

    …1721)"
    
    Fix pytest-dev#12021.
    Reopens pytest-dev#11706.
    
    This reverts commit 12b9bd5.
    
    This change caused a bad regression in pytest-xdist:
    pytest-dev/pytest-xdist#1024
    
    pytest-xdist necessarily has special handling of `--maxfail` and session
    fixture teardown get executed multiple times with the change.
    
    Since I'm not sure how to adapt pytest-xdist myself, revert for now.
    
    I kept the sticky `shouldstop`/`shouldfail` changes as they are good
    ideas regardless I think.
    bluetech committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    00d9640 View commit details
    Browse the repository at this point in the history