Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Cygwin NumPy to 1.26 in Python 3.9 #7875

Closed
wants to merge 6 commits into from

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented Mar 13, 2024

Removes the NumPy-pinning requirement noted in #7403.

Changes proposed in this pull request:

Cygwin has Netlib interfaces, NumPy CI uses them.  Let's see if we can force pip/meson to use them.
New NumPy uses CMake through meson, which needs dependencies.
@radarhere
Copy link
Member

Fixes #7403.

Ah, ok, you mean that the PR pinned NumPy on Cygwin, and this removes the pinning. Normally, I would only think of issues as being "fixed", not PRs that passed and were merged.

Necessary with version constraint, not without.

Co-authored-by: Andrew Murray <[email protected]>
@radarhere radarhere changed the title CI: Update Cygwin NumPy to 1.26 CI: Update Cygwin NumPy to 1.26 in Python 3.9 Mar 13, 2024
@radarhere
Copy link
Member

I've updated the PR title, as this only affects Python 3.9 - NumPy 1.24 is the last version to support Python 3.8, so this makes no difference for 3.8.

@radarhere
Copy link
Member

It turns out there is a problem, both in this PR and in main, and for both Python 3.8 and 3.9 - NumPy is not detected by the tests.

The tests can't find it, so check here.
There's a decent chance the cygwin/cygwin-install-action paths in egor-tensin/cleanup-path broke numpy import, since NumPy needs to find BLAS somewhere.
@DWesl
Copy link
Contributor Author

DWesl commented Mar 14, 2024

Looks like the switch to the egor-tensin Cygwin install action didn't catch all the places the default install path got used: in particular, the egor-tensin/cleanup-path specification of the new path, including the location of the BLAS and Lapack runtimes.

In any case, it looks like 3.8 and 3.9 are finding NumPy now.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

.github/workflows/test-cygwin.yml Outdated Show resolved Hide resolved
It's working again, so this isn't relevant anymore.

Co-authored-by: Hugo van Kemenade <[email protected]>
@radarhere
Copy link
Member

I've created #7880 as an alternative to this.

@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

We've merged #7880, but thanks for this PR that prompted that one :)

@hugovk hugovk closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants