Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python and NumPy pinning on Cygwin #7880

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Mar 15, 2024

Alternative to #7875

Two Cygwin changes

  1. Reverts Pin to Python 3.9.16-1 #7762, where Python was pinned to Python 3.9.16-1
  2. Removes the pinning of NumPy from NumPy now supports Python 3.12 #7403, but also goes further, and just uses the packaged NumPy. NumPy was originally upgraded in a commit entitled "CI: Try to get Cygwin workflow working.", so if there wasn't another need for this, then perhaps testing the package version is more valuable?

This also decreases the build time from 31m54s to 10m13s.

@DWesl
Copy link
Contributor

DWesl commented Mar 15, 2024

Tests pass, and include NumPy. I think 1.21 had problems with unaligned load, but that seems gone now.

src/PIL/Image.py Show resolved Hide resolved
@hugovk hugovk merged commit 786ded0 into python-pillow:main Mar 15, 2024
57 checks passed
@radarhere radarhere deleted the cygwin branch March 15, 2024 14:08
This was referenced Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants