Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper main python constraint when resolving for installation #2625

Merged

Conversation

sdispater
Copy link
Member

When implementing #2361 something was omitted that causes an issue when installing some dependencies with Python restrictions.

When resolving against the lock file, the main Python constraint used was still the package specified one which led to resolution errors.

This PR fixes it by using the current Python version instead, if available.

Pull Request Check List

Resolves: #2604

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added area/solver Related to the dependency resolver area/installer Related to the dependency installer labels Jul 3, 2020
@sdispater sdispater requested a review from a team July 3, 2020 12:51
@sdispater sdispater added this to the 1.1 milestone Jul 3, 2020
@sdispater sdispater added the kind/bug Something isn't working as expected label Jul 3, 2020
@sdispater sdispater merged commit d628947 into develop Jul 10, 2020
@sdispater sdispater deleted the use-proper-main-python-constraint-for-installation branch July 10, 2020 07:37
@sdispater sdispater mentioned this pull request Jul 10, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant