Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0a3 #2648

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Release 1.1.0a3 #2648

merged 4 commits into from
Jul 10, 2020

Conversation

sdispater
Copy link
Member

Added

  • New installer which provides a faster and better experience (#2595).

Fixed

  • Fixed resolution error when handling duplicate dependencies with environment markers (#2622).
  • Fixed erroneous resolution errors when resolving packages to install (#2625).
  • Fixed errors when detecting installed editable packages (#2602).

@sdispater sdispater added the kind/release Meta-issues/PRs as part of the release process label Jul 10, 2020
@sdispater sdispater merged commit 53868af into develop Jul 10, 2020
@sdispater sdispater deleted the release-1.1.0a3 branch July 10, 2020 10:00
@aviramha
Copy link
Contributor

Do we need to do anything to enable #2595 or is it enabled by default?
It doesn't seem faster :(

@sdispater
Copy link
Member Author

@aviramha It's enabled by default, yes. However, it's possible that on some CI systems the parallelization is not activated.

@aviramha
Copy link
Contributor

@aviramha It's enabled by default, yes. However, it's possible that on some CI systems the parallelization is not activated.

What do you mean by that? What kind of parallelization needs to be enabled?

@sdispater
Copy link
Member Author

@aviramha For now, there is nothing you can do to force the parallelization on some CI systems.

Note that I assumed that you were not seeing speed improvements in your CI because that's the only case where the parallelization might not be enabled, however if it's not the case I would like to know to track down the issue.

As a side note, the relevant code snippet that explains why it's not activated on some CI systems is here: https://github.com/python-poetry/poetry/blob/develop/poetry/installation/executor.py#L42

However, it was here more as a safety net in the first iterations on the feature and I think it can be removed now that it has been thoroughly tested.

@aviramha
Copy link
Contributor

You're correct the improvement isn't seen on bitbucket pipelines.

@aviramha
Copy link
Contributor

aviramha commented Jul 13, 2020

@sdispater I took the liberty of removing the check and sending a PR. I really want to speed up my CI :)
#2663

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/release Meta-issues/PRs as part of the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants