-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action for checking free-threaded build #111062
Comments
As I shared on the discord, I will proceed this issue during the PyCon APAC sprint :) |
We are going to set up the CI based on the reusable workflow that @hugovk suggested. |
Please also open an issue about creating a new label: https://github.com/python/core-workflow/issues/new/choose And see the end of the SC announcement:
So perhaps |
Taking MacOS for the sprint |
I am taking Linux |
Good example: #110794 (comment) |
For python#111062, in order to run nogil build/tests, separate the build into a reusable workflow first. syntax pass config_hash along one reusable per os typos typos cleanup🧼 cleanup🧼
@hugovk I will leave the name of reusable workflow to you since I am not sure which convention will be better. |
\# pythongh-111062: Build both default and free-threaded on macos
\# pythongh-111062: Build both default and free-threaded on macos
Now macOS CIs supports both default and free-threaded mode (just for |
Let's also backport to the 3.12 and 3.11 branches. Obviously the free-threading bits won't be backported, but it will help to have the rest of the structure matching to make it easier to backport other changes. |
…de as the conditional CI (python#111452) Co-authored-by: Donghee Na <[email protected]>
…pythongh-111494) pythongh-111062 Update name of reusable workflows for linux / macOS
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <[email protected]> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <[email protected]> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…111521) CI: Update skip lists
) CI: Move OS test jobs to reusable workflows Co-authored-by: Donghee Na <[email protected]>
) CI: Move OS test jobs to reusable workflows Co-authored-by: Donghee Na <[email protected]>
…de as the conditional CI (python#111452) Co-authored-by: Donghee Na <[email protected]>
…pythongh-111494) pythongh-111062 Update name of reusable workflows for linux / macOS
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <[email protected]> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <[email protected]> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…111521) CI: Update skip lists
…de as the conditional CI (python#111452) Co-authored-by: Donghee Na <[email protected]>
…pythongh-111494) pythongh-111062 Update name of reusable workflows for linux / macOS
…ode as the conditional CI (python#111493) * pythongh-111062 Set up free-threaded CI for windows Co-authored-by: Donghee Na <[email protected]> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <[email protected]> * Update * Update names * Add files * Update * Revert "Update" This reverts commit 4f17e1a. * fix --------- Co-authored-by: juanjose.tenorio <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…111521) CI: Update skip lists
Currently, nogil build has been added to buildbot, but it is inconvenient to check whether it is working properly in the PR stage.
So I would like to suggest: Putting a CI that checks nogil builds in Github Action.
This will satisfy the following conditions:
(e.g gh-263: Run Python 3.12 task as the experimental task pyperformance#274)
If this happens, it will be very helpful in reviewing nogil-related PRs.
Linked PRs
The text was updated successfully, but these errors were encountered: