Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111062: Separate linux build into a reusable workflow #111446

Closed
wants to merge 19 commits into from

Conversation

NCLI
Copy link
Contributor

@NCLI NCLI commented Oct 29, 2023

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

This comment was marked as resolved.

@@ -0,0 +1,84 @@
name: Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

contents: read

jobs:
name: 'Ubuntu reusable'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

@NCLI NCLI changed the title GH-111062 Reusable ubuntu workflowfor build test GH-111062 Separate linux build into a reusable workflow Oct 29, 2023
Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 😄

@NCLI NCLI marked this pull request as ready for review October 29, 2023 07:00
@hugovk hugovk changed the title GH-111062 Separate linux build into a reusable workflow gh-111062: Separate linux build into a reusable workflow Oct 29, 2023
@hugovk
Copy link
Member

hugovk commented Oct 29, 2023

Looking good, let's first decide on the name, re: #111062 (comment)

reusable-build-ubuntu.yml, or reusable-ubuntu.yml to match reusable-docs.yml?

@corona10
Copy link
Member

Duplicated with #111452

@corona10 corona10 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants