Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a few bits from compiler to earlier stages to simplify the compiler #121272

Closed
iritkatriel opened this issue Jul 2, 2024 · 0 comments
Closed
Assignees

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Jul 2, 2024

There are validations in compile.c that can move to earlier stages (AST validation or symtable construction).

And the compiler is modifying the symbol table (setting ste_coroutine), which it really shouldn't be doing.

This will simplify the compiler, which is one of the largest code components of the interpreter.

Linked PRs

@iritkatriel iritkatriel self-assigned this Jul 2, 2024
@terryjreedy terryjreedy changed the title Move input validation from compiler to earlier stages Move import validation from compiler to earlier stages Jul 2, 2024
@iritkatriel iritkatriel changed the title Move import validation from compiler to earlier stages Move a few bits from compiler to earlier stages to simplify the compiler Jul 2, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 2, 2024
Akasurde pushed a commit to Akasurde/cpython that referenced this issue Jul 3, 2024
iritkatriel added a commit that referenced this issue Jul 3, 2024
compiler no longer modifies the symtable after this.
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 3, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 4, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 4, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant