gh-121272: move async for/with validation from compiler to symtable #121361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
requested review from
JelleZijlstra,
carljm and
markshannon
as code owners
JelleZijlstra
approved these changes
Jul 4, 2024
picnixz
reviewed
Jul 4, 2024
| @@ -251,6 +256,7 @@ static int symtable_visit_withitem(struct symtable *st, withitem_ty item); | |||
| static int symtable_visit_match_case(struct symtable *st, match_case_ty m); | |||
| static int symtable_visit_pattern(struct symtable *st, pattern_ty s); | |||
| static int symtable_raise_if_annotation_block(struct symtable *st, const char *, expr_ty); | |||
| static int symtable_raise_if_not_coroutine(struct symtable *st, const char *msg, _Py_SourceLocation loc); | |||
There was a problem hiding this comment.
Other functions have a signature that take the statement or expression as a parameter instead of the location directly. So maybe you could do the same here and just call LOCATION(s) when you call SET_ERROR_LOCATION?
There was a problem hiding this comment.
That would unnecessarily make this function specific to stmt_ty. There is likely to be an expr_ty luse case for it as well.
In general, a function is ideally passed what it actually needs (unless its purpose is to abstract something out).
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test are tested in test_bultin:
test_compile_top_level_await_invalid_casesandtest_compile_top_level_await.