Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105539: Fix ResourceWarning from unclosed SQLite connection in ClosedCurTests. #108360

Merged
merged 1 commit into from
Aug 23, 2023
Merged

gh-105539: Fix ResourceWarning from unclosed SQLite connection in ClosedCurTests. #108360

merged 1 commit into from
Aug 23, 2023

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Aug 23, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 23, 2023
Closed
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 23, 2023
@felixxm felixxm mentioned this pull request Aug 23, 2023
Merged
@felixxm felixxm force-pushed the gh-105539-resource-warning branch 2 times, most recently from 0fe2b88 to 02851c2 Compare August 23, 2023 07:46
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 23, 2023 07:50
@erlend-aasland erlend-aasland linked an issue Aug 23, 2023 that may be closed by this pull request
Emit resource warning if sqlite3 fails to close the database #105539
Closed
auto-merge was automatically disabled August 23, 2023 09:21

Head branch was pushed to by a user without write access

@felixxm
Copy link
Contributor Author

felixxm commented Aug 23, 2023

@erlend-aasland I found and fixed one more:

./python -m test -R : test_audit

@erlend-aasland
Copy link
Contributor

@erlend-aasland I found and fixed one more:

./python -m test -R : test_audit

Good catch!

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 23, 2023 09:26
@erlend-aasland erlend-aasland merged commit 29bc616 into python:main Aug 23, 2023
15 checks passed
@erlend-aasland
Copy link
Contributor

Thanks, Mariusz!

@felixxm felixxm deleted the gh-105539-resource-warning branch August 23, 2023 10:59
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit resource warning if sqlite3 fails to close the database
3 participants
@felixxm @erlend-aasland @bedevere-bot