Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas #111504

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

encukou
Copy link
Member

@encukou encukou commented Oct 30, 2023

Here's more text on how to avoid the GC-related gotchas when defining heap types.

(See also: capi-workgroup/problems#49)


📚 Documentation preview 📚: https://cpython-previews--111504.org.readthedocs.build/

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this, @encukou! I think this is a nice improvement, though I'll rely on @1st1 to say for sure. 😄 I've left a few small comments.

Doc/howto/isolating-extensions.rst Show resolved Hide resolved
Doc/howto/isolating-extensions.rst Outdated Show resolved Hide resolved
Doc/howto/isolating-extensions.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2023

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ericsnowcurrently
Copy link
Member

@pablogsal, do you think this change would have helped Yury get things right without your help?

@pablogsal
Copy link
Member

@pablogsal, do you think this change would have helped Yury get things right without your help?

Yup! This is indeed fantastic. Thank you @ericsnowcurrently and @encukou

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit 985679f into python:main Nov 16, 2023
24 of 25 checks passed
@encukou encukou deleted the howto-clarifications branch November 16, 2023 11:05
@encukou encukou added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 16, 2023
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2023
…otchas (pythonGH-111504)

(cherry picked from commit 985679f)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Eric Snow <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2023
…otchas (pythonGH-111504)

(cherry picked from commit 985679f)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Eric Snow <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2023

GH-112147 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 16, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2023

GH-112148 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 16, 2023
encukou added a commit that referenced this pull request Nov 16, 2023
…gotchas (GH-111504) (GH-112147)

gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas (GH-111504)
(cherry picked from commit 985679f)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Eric Snow <[email protected]>
encukou added a commit that referenced this pull request Nov 16, 2023
…gotchas (GH-111504) (GH-112148)

gh-110812: Isolating Extension Modules HOWTO: List GC-related gotchas (GH-111504)
(cherry picked from commit 985679f)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Eric Snow <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants