gh-88516: show file proxy icon in IDLE editor windows on macOS #112894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour.
The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon.
|
@terryjreedy, could you please review this PR? I'd prefer to merge this because this improves IDLE on macOS without big changes from cross-platform behaviour. |
|
@terryjreedy, I intent to merge this tomorrow afternoon (CET timezone). It is a minor change, but aligns the GUI better with platform conventions without IMHO making it too different from other platforms. |
terryjreedy
requested changes
Feb 3, 2024
|
When you're done making the requested changes, leave the comment: |
Co-authored-by: Terry Jan Reedy <[email protected]>
|
I have made the requested changes; please review again. |
terryjreedy
added
needs backport to 3.11
terryjreedy
approved these changes
Feb 23, 2024
|
Test failures were flakey test_queue, since fixed. Set to automerge and backport. |
|
Thanks @ronaldoussoren for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 23, 2024
…ythonGH-112894) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. (cherry picked from commit b481018) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-115840 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 23, 2024
…ythonGH-112894) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. (cherry picked from commit b481018) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-115841 is a backport of this pull request to the 3.11 branch. |
terryjreedy
added a commit
that referenced
this pull request
Feb 23, 2024
…GH-112894) (#115840) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. (cherry picked from commit b481018) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy
added a commit
that referenced
this pull request
Feb 23, 2024
…GH-112894) (#115841) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. (cherry picked from commit b481018) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
smontanaro
pushed a commit
to smontanaro/cpython
that referenced
this pull request
Feb 23, 2024
… macOS (pythonGH-112894) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. (cherry picked from commit b481018) Co-authored-by: Ronald Oussoren <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…ython#112894) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. Co-authored-by: Terry Jan Reedy <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ython#112894) The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour. Don't use both the long and short names in the window title. The behaviour of other editors (such as Text Editor) is to show only the short name with the proxy icon. Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform standard on macOS is to show a proxy icon for open files in the titlebar of Windows. Make sure IDLE matches this behaviour.
Also: