Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-88516: show file proxy icon in IDLE editor windows on macOS #112894

Merged
merged 4 commits into from
Feb 23, 2024
Merged

gh-88516: show file proxy icon in IDLE editor windows on macOS #112894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
079437d
gh-88516: show file proxy icon in IDLE editor windows on macOS
ronaldoussoren Dec 9, 2023
37295a1
Don't use both the long and short names in the window title
ronaldoussoren Dec 9, 2023
1611a59
Also maintain the window modification status
ronaldoussoren Dec 9, 2023
b27b374
Apply suggestions from code review
ronaldoussoren Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,9 @@ def open_recent_file(fn_closure=file_name):
def saved_change_hook(self):
short = self.short_title()
long = self.long_title()
if short and long:
if short and long and not macosx.isCocoaTk():
# Don't use both values on macOS because
# that doesn't match platform conventions.
title = short + " - " + long + _py_version
elif short:
title = short
Expand All @@ -1058,6 +1060,13 @@ def saved_change_hook(self):
self.top.wm_title(title)
self.top.wm_iconname(icon)

if macosx.isCocoaTk():
# Add a proxy icon to the window title
self.top.wm_attributes("-titlepath", long)

# Maintain the modification status for the window
self.top.wm_attributes("-modified", not self.get_saved())
terryjreedy marked this conversation as resolved.
Show resolved Hide resolved

def get_saved(self):
return self.undo.get_saved()

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2023-12-09-11-04-26.gh-issue-88516.SIIvfs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
On macOS show a proxy icon in the title bar of editor windows to match
platform behaviour.
Loading