Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115663: Remove 'regen-sbom' from the 'regen-all' target #115790

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Feb 21, 2024

This PR removes the regen-sbom target from regen-all, since it's only meant to be run by CPython CI and not by downstream distributors.

@hugovk
Copy link
Member

hugovk commented Feb 22, 2024

@befeleme @hroncok How does this look?

@hroncok
Copy link
Contributor

hroncok commented Feb 22, 2024

Pretty much the same as ours 👍

fedora-python@8e2c1eb

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@hugovk hugovk merged commit c6a47de into python:main Feb 22, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sethmlarson and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c6a47de70966e6899871245e800a0a9271e25b12 3.12

@sethmlarson sethmlarson deleted the regen-sbom-not-in-all branch February 22, 2024 13:59
sethmlarson added a commit to sethmlarson/cpython that referenced this pull request Feb 22, 2024
…et (pythonGH-115790)

(cherry picked from commit c6a47de)

Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 22, 2024

GH-115820 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 22, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 22, 2024

GH-115820 is a backport of this pull request to the 3.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants