[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)" #18526
Conversation
| @@ -0,0 +1,4 @@ | |||
| In "bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)", the | |||
| change broke the backwards compatibility of an undefined parsing behavior in | |||
| a patch release. The behavior was relied upon by users. A decision was taken | |||
There was a problem hiding this comment.
I think we should explicitly mention the releases involved. For 3.7, how about something like:
The original fix for bpo-27657, "Fix urlparse() with numeric paths" (GH-16839)
included in 3.7.6, inadvertently introduced a behavior change that broke several third-party packages relying on the original undefined parsing behavior. The change is reverted in 3.7.7, restoring the behavior of 3.7.5 and earlier releases.
There was a problem hiding this comment.
Thanks, Ned. I have adopted this suggestion.
|
When you're done making the requested changes, leave the comment: |
This reverts commit 82b5f6b. The change broke the backwards compatibility of parsing behavior in a patch release of Python (3.7.6). A decision was taken to revert this patch in 3.7.7. In https://bugs.python.org/issue27657 it was decided that the previous behavior like >>> urlparse('localhost:8080') ParseResult(scheme='', netloc='', path='localhost:8080', params='', query='', fragment='') >>> urlparse('undefined:8080') ParseResult(scheme='', netloc='', path='undefined:8080', params='', query='', fragment='') needs to be preserved in patch releases as number of users rely upon it. Explicitly mention the releases involved with the revert in NEWS. Adopt the wording suggested by @ned-deily.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
|
@orsenthil: Please replace |
This reverts commit 82b5f6b.
The change broke the backward compatibility of parsing behavior in a
patch release of Python (3.7.6). A decision was taken to revert this
patch in 3.7.7.
In https://bugs.python.org/issue27657 it was decided that the previous
behavior like
needs to be preserved in patch releases as users rely upon it.
https://bugs.python.org/issue27657