Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)" #18526

Merged
merged 1 commit into from
Feb 16, 2020
Merged

[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)" #18526

merged 1 commit into from
Feb 16, 2020

Commits on Feb 16, 2020

  1. Revert "bpo-27657: Fix urlparse() with numeric paths (GH-661)"

    This reverts commit 82b5f6b.
    
    The change broke the backwards compatibility of parsing behavior in a
    patch release of Python (3.7.6). A decision was taken to revert this
    patch in 3.7.7.
    
    In https://bugs.python.org/issue27657 it was decided that the previous
    behavior like
    
    >>> urlparse('localhost:8080')
    ParseResult(scheme='', netloc='', path='localhost:8080', params='', query='', fragment='')
    
    >>> urlparse('undefined:8080')
    ParseResult(scheme='', netloc='', path='undefined:8080', params='', query='', fragment='')
    
    needs to be preserved in patch releases as number of users rely upon it.
    
    Explicitly mention the releases involved with the revert in NEWS.
    Adopt the wording suggested by @ned-deily.
    orsenthil committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    c703e5d View commit details
    Browse the repository at this point in the history