Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect design of handlers (Frequency, RunningAverage, etc.) #1567

Closed
wants to merge 10 commits into from

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented Jan 22, 2021

Fixes #1405

Description:

  • Frequency : introduction of a specific usage FrequencyWise to fit the Metric.attach() api.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@sdesrozis sdesrozis changed the title Fix incorrect design of handlers (Frequency, RunningAverage, etc.) [WIP] Fix incorrect design of handlers (Frequency, RunningAverage, etc.) Jan 22, 2021
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @sdesrozis !

ignite/metrics/frequency.py Show resolved Hide resolved
@sdesrozis sdesrozis marked this pull request as ready for review February 2, 2021 08:16
@sdesrozis sdesrozis changed the title [WIP] Fix incorrect design of handlers (Frequency, RunningAverage, etc.) Fix incorrect design of handlers (Frequency, RunningAverage, etc.) Feb 2, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 2, 2021

@sdesrozis thanks for the update! I was thinking as Checkpoint and ModelCheckpoint fix is the most simple and we do not break other things, it would be better to do it in a separate PR. For others, I'm not yet sure about the fix to adopt.

@sdesrozis
Copy link
Contributor Author

Ok so if I understand correctly, I do a new PR with last commits about ModelCheckpoint fix, right ? And let's see for others ?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 2, 2021

Exactly!

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 6, 2021

To be honest currently I'm not that sure about introducing things in this way. Let's try to find a better design that you already told previously about... I'd prefer to keep things as is instead of introducing a half-good solution. What do you think ?

@sdesrozis
Copy link
Contributor Author

Not relevant at the moment. I prefer close this PR.

@sdesrozis sdesrozis closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect design for RunningAverage, Frequency, ModelCheckpoint, ...
2 participants