Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Checkpoint and ModelCheckpoint consistency #1606

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Fix for Checkpoint and ModelCheckpoint consistency #1606

merged 1 commit into from
Feb 2, 2021

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented Feb 2, 2021 •
edited by vfdev-5
Loading

Partially addresses #1405

Description:

Solve ModelCheckpoint and Checkpoint consistency. Now to_saveis no longer optional.

Cherry pick from #1567
commit 89d4312

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5
vfdev-5 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdesrozis !

@vfdev-5 vfdev-5 merged commit 38bcba6 into pytorch:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdesrozis @vfdev-5