Fix Classification Parameters closes #305

[aorgazf]

The PR fixes the bug introduced in the calculation of the rotation angle and threshold of the calibrate_qubit_states_fit function.
With this fix, AllXYs work again.

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.

[codecov]

Codecov Report

Merging #308 (81cf97f) into main (598e862) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   37.85%   37.89%   +0.04%     
==========================================
  Files          42       42              
  Lines        2800     2797       -3     
==========================================
  Hits         1060     1060              
+ Misses       1740     1737       -3     

Flag	Coverage Δ
unittests	37.89% <0.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/qibocal/fitting/methods.py	72.69% <0.00%> (+0.76%)	⬆️

[Edoardo-Pedicillo]

At this point I think you can drop this two lines

qibocal/src/qibocal/fitting/methods.py

Lines 1030 to 1031 in 159c5ed

	iq_state0_translated = iq_state0 - origin
	iq_state1_translated = iq_state1 - origin

[andrea-pasquale]

At this point I think you can drop this two lines

qibocal/src/qibocal/fitting/methods.py

Lines 1030 to 1031 in 159c5ed

	iq_state0_translated = iq_state0 - origin
	iq_state1_translated = iq_state1 - origin

+1

[andrea-pasquale]

I'll go ahead and merge this PR.