-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug iq_angle and threshold in autocalibration methods and hw methods #311
Conversation
@aorgazf @Edoardo-Pedicillo @andrea-pasquale I have introduced the changes needed to fix threshodl and rotation angle calcultion introduced by @aorgazf in PR #308. The difference is that this PR includes the fixes in HW and autocalibration routines. I have tried allXY after running classification and now it works as expected. |
@aorgazf thanks for fixing the bug. I have tested and it works as expected now. I have raised a PR (#311 ) that includes your fixes. But the only thing is taht we should included the fixes in HW and autocal routines (not included in this branch). So, probably, if you agree (@Edoardo-Pedicillo @andrea-pasquale @aorgazf ) we can close this branch and merge #311 in #279 wich contains all the methods refactored for autocalibration. |
@aorgazf please note that now, the iq_angle is now calculated by default in radians to be compatible with all platform runcards, but during the autocalibration, we will convert into degrees before updating qblox runcard. |
for more information, see https://pre-commit.ci
…eam/qibocal into david/fixes_split_data_fit
for more information, see https://pre-commit.ci
changes included in https://github.com/qiboteam/qibocal/tree/david/fixes_split_data_fit |
Fixed bug iq_angle and threshold in autocalibration methods and hardware methods.
Checklist: