Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug iq_angle and threshold in autocalibration methods and hw methods #311

Closed
wants to merge 10 commits into from

Conversation

DavidSarlle
Copy link
Contributor

Fixed bug iq_angle and threshold in autocalibration methods and hardware methods.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@DavidSarlle
Copy link
Contributor Author

DavidSarlle commented Apr 25, 2023

@aorgazf @Edoardo-Pedicillo @andrea-pasquale I have introduced the changes needed to fix threshodl and rotation angle calcultion introduced by @aorgazf in PR #308. The difference is that this PR includes the fixes in HW and autocalibration routines.
Also I have included some fitting parameters that were removed from HW routines and the reports.

I have tried allXY after running classification and now it works as expected.

@DavidSarlle
Copy link
Contributor Author

@aorgazf thanks for fixing the bug. I have tested and it works as expected now. I have raised a PR (#311 ) that includes your fixes. But the only thing is taht we should included the fixes in HW and autocal routines (not included in this branch). So, probably, if you agree (@Edoardo-Pedicillo @andrea-pasquale @aorgazf ) we can close this branch and merge #311 in #279 wich contains all the methods refactored for autocalibration.

@DavidSarlle
Copy link
Contributor Author

@aorgazf please note that now, the iq_angle is now calculated by default in radians to be compatible with all platform runcards, but during the autocalibration, we will convert into degrees before updating qblox runcard.

@DavidSarlle
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant