Add optimal integration weights routine #383
Conversation
Jacfomg
added
do not merge
Jacfomg
removed
the
do not merge
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 96.77% 96.85% +0.08%
==========================================
Files 48 49 +1
Lines 3128 3209 +81
==========================================
+ Hits 3027 3108 +81
Misses 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| for q in self.optimal_integration_weights.keys(): | ||
| # """Helper function to use np.savez while converting keys into strings.""" | ||
| np.savez( | ||
| path / f"optimal_integration_weights_q{q}.npz", | ||
| self.optimal_integration_weights[q], | ||
| ) |
There was a problem hiding this comment.
The advantage of npz is that you can store multiple arrays. Therefore you don't need a specific file for each qubit. Unless you are doing this on purpose.
There was a problem hiding this comment.
Yeah, if I have them is separate files I think it will be easier to handle them, at least now. So if you were recalibrating some qubits you can let the files for the others untouched. If not you will need to calibrate them all to have the file, right ?
src/qibocal/protocols/characterization/signal_experiments/optimal_integration_weights.py
Outdated
Show resolved
Hide resolved
|
I'm closing this as outdated but I will keep the branch, I will also open an issue to keep track of it. |
Add integration weights. I would say it would need a way to save the fitting, #395, so I can get the integration weights and pass them to the devices.
Need to read a bit to understand what I get from the hardware.
https://arxiv.org/pdf/1711.05336.pdf and its 29 reference.
Checklist: