-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable raw acquisition for rfsoc #480
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 59.32% 59.24% -0.08%
==========================================
Files 37 37
Lines 6203 6211 +8
==========================================
Hits 3680 3680
- Misses 2523 2531 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This PR is ready, but there are a few things to note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the discussion on new-style type hints, this PR seems good to go.
if len(sequence.ro_pulses) != 1: | ||
raise NotImplementedError("Raw data acquisition is compatible only with a single readout") | ||
if execution_parameters.averaging_mode is not AveragingMode.CYCLIC: | ||
raise NotImplementedError("Raw data acquisition can only be averaged") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested if it only allows a single waveform to be acquired ? Maybe it is useful if 2 fit in memory for readout crosstalk analysis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jacfomg, you are right and I'll try!
I could probably add something more sofisticated than just counting the readout pulses... In fact also single readout pulse, very long, could fill the memory...
In any case, I think all of these are just general improvements and not really required in the short term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. If you want to merge this now, you can transfer the discussion about multiple waveform acquisition to an issue (if you are planning to look at it later).
FYI, with QM could also not acquire shots of raw waveforms (AveragingMode.SINGLESHOT
doesn't work with AcquisitionType.RAW
), so for nshots > 1 I could only get the averaged waveform. However, I don't remember for sure, but I believe I could get multiple waveforms by playing multiple readout pulses (on different qubits) at the same time.
As title says, this PR should implement raw acquisition (for pulse sequences) for the rfsocs.
It should be ok, but I'm waiting to test it.
Checklist: