-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qibolab benchmarks #433
Qibolab benchmarks #433
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 96.77% 96.78% +0.01%
==========================================
Files 48 48
Lines 3129 3145 +16
==========================================
+ Hits 3028 3044 +16
Misses 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What do you think about those scans for the scaling ? I need to reduce the rabi amp points I think. |
I think it's useful to always have the 1 (a single point in the sweep) that more or less is equal to the overhead for an execution. Then I would propose to have, for all the parameters, the same numbers of point in power of 10: |
Co-authored-by: Andrea Pasquale <[email protected]>
Co-authored-by: Rodolfo Carobene <[email protected]>
for more information, see https://pre-commit.ci
@stavros11 @Jacfomg I've pushed a runcard for the scalings in 1D. in every routine the points are With a If you can execute them it would be nice, if you have other proposals please feel free to propose them :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will try soon. The runcard is scaling/1d_sweepers.yml? There is another runcard for scaling in iqm that has different point values, we need to make sure everyone is using the same.
runcards/scaling/1d_sweepers.yml
Outdated
# max_amp_factor: 1.0000 | ||
# step_amp_factor: 1 | ||
# pulse_length: 40 | ||
# relaxation_time: 5_000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relaxation times here are different than the other benchmark. Since we are not using a qubit it is fine to do even Rabi with very short relaxation time, just need to make sure we report it properly in the paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that was my point, but in any case we can change it.
I used scaling/1d_sweepers.yml
that I derived from the one proposed by Juan
What is the plan for this PR @Jacfomg @stavros11? |
This also saved times inside of the drivers I think, but in the end we decided not to use them. So, I would say that this PR is only important now because it has the runcards we used for the timings. We should save them somewhere. |
I see, then I suggest to open a separate PR just to upload the runcards used in the qibolab paper. |
Replaces #415 for the benchmarks
I merged main and some fix for dispersive shift. Now the execution produces a file called "timings.json" with the important info.