-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logs #442
Adding logs #442
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 97.03% 97.05% +0.01%
==========================================
Files 48 48
Lines 3107 3126 +19
==========================================
+ Hits 3015 3034 +19
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Usually the fit takes almost nothing, could we add a check to only log that time when is above a threshold (1s maybe) ? |
I kinda liked the "timing.json" file that we are producing for the benchmarks... Now that the the process is nicely written do you think we could have it directly in qibocal or is it useless? |
Yep, I can put a threshold. Maybe 1 second is too much (?) |
I need to see if there is a way to retrieve the information from the decorator. I feel like we don't need another json. |
Co-authored-by: Rodolfo Carobene <[email protected]>
for more information, see https://pre-commit.ci
Just to a give an update now the timings are stored in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
This PR adds some logs in order to show which protocol is being executed.
The timing of both the acquisition and the fitting are shown for each protocol.
Here is an example
Checklist: