-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiqubit sections layout #50
Conversation
Thanks, the layout looks okay. For the indent I think there are some options:
|
Thanks, I added extra spaces before qubits, I think it looks better now.
I also thought about making the action name collapsable. This may be useful if we have runcards with many actions or many qubits. Let me know if you prefer to do it this way. |
Looks good, thanks. If you try to downgrade the indent does it look fine? |
Looks fine to me. Please have a look with the last commit and if you don't like it we can revert to the previous version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this @stavros11.
Here I followed exactly the layout from #46, an alternative is to put the plots refering to the same qubit together, eg. Freq. vs Att Qubit 0, MSR vs Freq. Qubit 0, Freq. vs Att. Qubit 1, MSR vs Freq Qubit 1, etc.. Let me know what you prefer.
Personally I prefer the second option instead of the layout in #46.
Probably if the user wants to compare directly the same plots for different qubits then this layout should work better. We can ask directly tomorrow during the meeting which is the best option.
This reverts commit 76c7e85.
@scarrazza I removed the qubit links from the sidebar, as we discussed. Please have a look and let me know.
I think the layout Andrea means here is the following:
What we have now in this branch is:
Since we decided to drop the qubit links from the sidebar, I think the second approach is the only way to go. |
Thanks, looks good to me. |
Thanks for the update @stavros11.
Yes, this is what I meant.
I also agree, at this point the second approach makes more sense. |
@stavros11 can we merge this now? |
Yes, this is good to merge from my side. |
Fixes #46.
@scarrazza @andrea-pasquale please have a look that the sidebar and the sections look as you had in mind and also that the links work as expected. Here I followed exactly the layout from #46, an alternative is to put the plots refering to the same qubit together, eg. Freq. vs Att Qubit 0, MSR vs Freq. Qubit 0, Freq. vs Att. Qubit 1, MSR vs Freq Qubit 1, etc.. Let me know what you prefer.
@scarrazza do you know how I can add an additiona indent to the qubit sections in the sidebar? Now it is aligned with the plot title, I would like to push it a bit further inside.