Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiqubit sections layout #50

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Fix multiqubit sections layout #50

merged 5 commits into from
Sep 1, 2022

Conversation

stavros11
Copy link
Member

Fixes #46.

@scarrazza @andrea-pasquale please have a look that the sidebar and the sections look as you had in mind and also that the links work as expected. Here I followed exactly the layout from #46, an alternative is to put the plots refering to the same qubit together, eg. Freq. vs Att Qubit 0, MSR vs Freq. Qubit 0, Freq. vs Att. Qubit 1, MSR vs Freq Qubit 1, etc.. Let me know what you prefer.

@scarrazza do you know how I can add an additiona indent to the qubit sections in the sidebar? Now it is aligned with the plot title, I would like to push it a bit further inside.

@scarrazza
Copy link
Member

@scarrazza do you know how I can add an additiona indent to the qubit sections in the sidebar? Now it is aligned with the plot title, I would like to push it a bit further inside.

Thanks, the layout looks okay. For the indent I think there are some options:

  • try an extra
      tag
    • add extra empty spaces (as we do for the plot names, using a "- " string)
    • downgrade the indent by 1 unit, i.e. remove "Actions" and simply write the action name instead.

@stavros11
Copy link
Member Author

Thanks, I added extra spaces before qubits, I think it looks better now.

  • downgrade the indent by 1 unit, i.e. remove "Actions" and simply write the action name instead.

I also thought about making the action name collapsable. This may be useful if we have runcards with many actions or many qubits. Let me know if you prefer to do it this way.

@scarrazza
Copy link
Member

Looks good, thanks. If you try to downgrade the indent does it look fine?

@stavros11
Copy link
Member Author

Looks good, thanks. If you try to downgrade the indent does it look fine?

Looks fine to me. Please have a look with the last commit and if you don't like it we can revert to the previous version.

@scarrazza
Copy link
Member

Yeah, looks better, but if the action name is too long the layout looks strange, e.g.:
image

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this @stavros11.

Here I followed exactly the layout from #46, an alternative is to put the plots refering to the same qubit together, eg. Freq. vs Att Qubit 0, MSR vs Freq. Qubit 0, Freq. vs Att. Qubit 1, MSR vs Freq Qubit 1, etc.. Let me know what you prefer.

Personally I prefer the second option instead of the layout in #46.
Probably if the user wants to compare directly the same plots for different qubits then this layout should work better. We can ask directly tomorrow during the meeting which is the best option.

@stavros11
Copy link
Member Author

@scarrazza I removed the qubit links from the sidebar, as we discussed. Please have a look and let me know.

Personally I prefer the second option instead of the layout in #46. Probably if the user wants to compare directly the same plots for different qubits then this layout should work better. We can ask directly tomorrow during the meeting which is the best option.

I think the layout Andrea means here is the following:

Resonator Punchout
  - Frequency vs Attenuation - Qubit 0
  - MSR vs Frequency - Qubit 0
  - Frequency vs Attenuation - Qubit 1
  - MSR vs Frequency - Qubit 1
  - ...

What we have now in this branch is:

Resonator Punchout
  - Frequency vs Attenuation - Qubit 0
  - Frequency vs Attenuation - Qubit 1
  - ...
  - MSR vs Frequency - Qubit 0
  - MSR vs Frequency - Qubit 1
  - ...

Since we decided to drop the qubit links from the sidebar, I think the second approach is the only way to go.

@scarrazza
Copy link
Member

Thanks, looks good to me.

@andrea-pasquale
Copy link
Contributor

Thanks for the update @stavros11.

Personally I prefer the second option instead of the layout in #46. Probably if the user wants to compare directly the same plots for different qubits then this layout should work better. We can ask directly tomorrow during the meeting which is the best option.

I think the layout Andrea means here is the following:

Resonator Punchout
  - Frequency vs Attenuation - Qubit 0
  - MSR vs Frequency - Qubit 0
  - Frequency vs Attenuation - Qubit 1
  - MSR vs Frequency - Qubit 1
  - ...

What we have now in this branch is:

Resonator Punchout
  - Frequency vs Attenuation - Qubit 0
  - Frequency vs Attenuation - Qubit 1
  - ...
  - MSR vs Frequency - Qubit 0
  - MSR vs Frequency - Qubit 1
  - ...

Yes, this is what I meant.

Since we decided to drop the qubit links from the sidebar, I think the second approach is the only way to go.

I also agree, at this point the second approach makes more sense.

@scarrazza
Copy link
Member

@stavros11 can we merge this now?

@stavros11
Copy link
Member Author

@stavros11 can we merge this now?

Yes, this is good to merge from my side.

@scarrazza scarrazza merged commit 8b59127 into add_routines Sep 1, 2022
@stavros11 stavros11 deleted the fixqubitlayout branch September 27, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants