Couplers Resonator Spec

[Jacfomg]

Draft routines, some loops missing and remove fitting from reused plots. Works with qibolab :qiboteam/qibolab#623 and qibolab_platforms []

Resonator:

Qubit:

Related paper: https://dspace.mit.edu/handle/1721.1/119507

https://arxiv.org/pdf/1912.10721.pdf

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.
• Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
  • Qibo: master
  • Qibolab: main
  • Qibolab_platforms_qrc: main

[codecov]

Codecov Report

Merging #565 (ea04864) into main (158e7e6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   96.24%   96.27%   +0.02%     
==========================================
  Files          96       99       +3     
  Lines        6551     6705     +154     
==========================================
+ Hits         6305     6455     +150     
- Misses        246      250       +4     

Flag	Coverage Δ
unittests	96.27% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/qibocal/protocols/characterization/__init__.py	100.00% <100.00%> (ø)
...cterization/couplers/coupler_qubit_spectroscopy.py	100.00% <100.00%> (ø)
...ization/couplers/coupler_resonator_spectroscopy.py	100.00% <100.00%> (ø)
...bocal/protocols/characterization/couplers/utils.py	100.00% <100.00%> (ø)
...rotocols/characterization/flux_dependence/utils.py	84.37% <100.00%> (+0.82%)	⬆️

... and 1 file with indirect coverage changes

[andrea-pasquale]

Thanks @Jacfomg for implementing this.
You can find below some comments.
Mainly for improving the code.
I believe that there are also a lot of TODOs, are you planning to address those in this PR?

[Jacfomg]

I will try to do as much work on new routines while this calibration lasts and I would go over them later, help is appreciated of course

[DavidSarlle]

@Jacfomg @andrea-pasquale The missing point in this routines are the fittings. We should be able to extract information about the couplers points, at least what are the bias values where the interaction between qubits or qubit and coupler are present.

[Jacfomg]

Sure, please work on that, I'm have other stuff I have to take off as lab stuff is not my work anymore.

[andrea-pasquale]

Another small comments

[andrea-pasquale]

What is the criteria for choosing which qubit to readout?

[Jacfomg]

I haven't played a lot with those, ideally you will measure both but to avoid any crosstalk I got only one and the one that was not the center qubit to ensure I was getting the coupler I wanted and not something coming from another coupler.

[andrea-pasquale]

Another small comments

[Edoardo-Pedicillo]

@Edoardo-Pedicillo @andrea-pasquale Should we delete this then?

No, the default register_qubit does not work with routines with 2D plots

[GabrielePalazzo]

From my side I think it's almost ready to be merged.

[GabrielePalazzo]

Seems ok to me.

[andrea-pasquale]

Another bunch of comments mainly improving documentation and plotting

[andrea-pasquale]

Thanks @Jacfomg