Couplers2

[Jacfomg]

Changes to adress the coupler and sweep their bias. Works with qibocal qiboteam/qibocal#565 and qibolab_platforms []

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.

[codecov]

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
src/qibolab/couplers.py	90.90% <100.00%> (+1.43%)	⬆️
src/qibolab/native.py	99.45% <100.00%> (+4.91%)	⬆️
src/qibolab/pulses.py	92.26% <100.00%> (+0.25%)	⬆️
src/qibolab/serialize.py	100.00% <100.00%> (ø)
src/qibolab/platform.py	78.31% <59.09%> (-2.17%)	⬇️
src/qibolab/instruments/zhinst.py	77.81% <71.73%> (-0.75%)	⬇️

📢 Thoughts on this report? Let us know!.

[Jacfomg]

Should we also add coupler pulses into the CZ so they get tested as well ?

[stavros11]

Should we also add coupler pulses into the CZ so they get tested as well ?

Yes, I think that would be good.

[Jacfomg]

Btw, @stavros11 any clue on the qm tests failing before I take a look ?

[GabrielePalazzo]

Apart from the only remark I have, it looks ok to me.

[Jacfomg]

Sorry to add this after your review @GabrielePalazzo I just found some timing issues when inspecting the pulse sequences being played on the device on the coupler routines.

[stavros11]

Thanks for the fixes. I did not review the driver update in detail as I am hoping to do a general pass over drivers soon, but otherwise looks good.

[Jacfomg]

Propagate comments on https://github.com/qiboteam/qibolab_platforms_qrc/compare/coupler2?expand=1

[stavros11]

Thanks for the updates @Jacfomg. I believe there is an issue with dumping platforms that contain pulses to couplers, for example if you try the following

from qibolab import create_platform
from qibolab.serialize import dump_runcard
from pathlib import Path

platform = create_platform("dummy")
dump_runcard(platform, Path(__file__).parent / "dummy_dump.yml")

it should dump the dummy runcard in a new yaml named dummy_dump.yml. Ideally this should look the same with the original dummy.yml, but if you look at it, the whole coupler section is missing from the native gates and the CZ/iSWAPs are also missing the coupler pulses.

[stavros11]

Thanks for the updates. Looks good to me now.