Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for extract_feature function #799

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

andrea-pasquale
Copy link
Contributor

Closes #798.

I removed the resonator_type check since it is not needed given that we will use just 2D resonators with flux tunable qubits. If someone can confirm this I can also drop the resonator_type from the data structure.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (808e23f) to head (7cfa4a6).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   97.19%   97.13%   -0.07%     
==========================================
  Files         104      104              
  Lines        7567     7786     +219     
==========================================
+ Hits         7355     7563     +208     
- Misses        212      223      +11     
Flag Coverage Δ
unittests 97.13% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...haracterization/flux_dependence/qubit_crosstalk.py 93.12% <100.00%> (+1.69%) ⬆️
...cterization/flux_dependence/resonator_crosstalk.py 95.03% <100.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit f3fb537 Apr 16, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_extract_feature branch April 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing 'extract_min_feature' and 'extract_max_feature'
3 participants