Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for extract_feature function #799

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Hotfix for extract_feature function #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/qibocal/protocols/characterization/flux_dependence/qubit_crosstalk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,18 +251,12 @@ def _fit(data: QubitCrosstalkData) -> QubitCrosstalkResults:

for target_flux_qubit, qubit_data in data.data.items():

if data.resonator_type == "3D":
frequencies, biases = utils.extract_min_feature(
qubit_data.freq,
qubit_data.bias,
qubit_data.signal,
)
else:
frequencies, biases = utils.extract_max_feature(
qubit_data.freq,
qubit_data.bias,
qubit_data.signal,
)
frequencies, biases = utils.extract_feature(
qubit_data.freq,
qubit_data.bias,
qubit_data.signal,
"max",
)
target_qubit, flux_qubit = target_flux_qubit

if target_qubit != flux_qubit:
Expand Down
15 changes: 3 additions & 12 deletions src/qibocal/protocols/characterization/flux_dependence/resonator_crosstalk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,18 +263,9 @@ def _fit(data: ResCrosstalkData) -> ResCrosstalkResults:
for target_flux_qubit, qubit_data in data.data.items():
target_qubit, flux_qubit = target_flux_qubit

if data.resonator_type == "3D":
frequencies, biases = utils.extract_max_feature(
qubit_data.freq,
qubit_data.bias,
qubit_data.signal,
)
else:
frequencies, biases = utils.extract_min_feature(
qubit_data.freq,
qubit_data.bias,
qubit_data.signal,
)
frequencies, biases = utils.extract_feature(
qubit_data.freq, qubit_data.bias, qubit_data.signal, "min"
)

if target_qubit != flux_qubit:
# fit function needs to be defined here to pass correct parameters
Expand Down
Loading