David/qubit tracking #581
David/qubit tracking #581
Conversation
for more information, see https://pre-commit.ci
…bolab into david/qubit_tracking
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Thanks @DavidSarlle. I merged main here because some changes that are already main were appearing in the changes.
It should be fine to merge this now, but we should keep in mind that the update method will be removed when qiboteam/qibocal#526 is merged. @andrea-pasquale please coordinate with @DavidSarlle to properly migrate these updates to the corresponing routines in qibocal.
I will review soon qiboteam/qibocal#519 and I will eventually open a PR on top of that one to fix the update. |
There was a problem hiding this comment.
Thanks @DavidSarlle, the code looks good to me.
I will just remove a few lines to avoid creating conflicts with qiboteam/qibocal#526 and #596. I will port those lines in qibocal.
src/qibolab/qubits.py
Outdated
| sweetspot: float = 0.0 | ||
| flux_to_bias: float = 0.0 | ||
| asymmetry: float = 0.0 | ||
| brf: float = 0.0 |
There was a problem hiding this comment.
@DavidSarlle what is the final decision for this? Here we are still using brf but in qiboteam/qibolab_platforms_qrc#54 you changed to bare_resonator_frequency_sweetspot.
There was a problem hiding this comment.
Depending on this I will also update qiboteam/qibocal#538
Personally I think that we should use bare_resonator_frequency_sweetspot.
Also ssf_brf could be renamed to something like ratio_sweetspot_qubit_freq_bare_resonator_freq which is pretty long but at least we know what it is.
There was a problem hiding this comment.
Sorry @stavros11 and @andrea-pasquale I forgot to push the latest changes where I modified the brf name to bare_resonator_frequency_sweetspot.
@andrea-pasquale regarding the ssf_brf, we can modifiy it as you said, but is a very large name for a variable... I have also included the docstrings with the explanation, so I think is better if we keep it as it is...
There was a problem hiding this comment.
I agree, I will not argue for the name of a single variable.
Let's keep ssf_brf and merge this PR.
There was a problem hiding this comment.
Great, if everyone agrees, please merge this when the CI passes.
…bolab into david/qubit_tracking
This PR adds the parameters need during the qubit flux tracking implemented in qibocal (https://github.com/qiboteam/qibocal/tree/david/qubit_flux_track).
The PR is compatible with all the runcards available in main and qibocal. So we can proceed to merge as soon as the reviewers accept it.
Checklist: