Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pandas 1.4.0 breaks Yahoo Finance library #133

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Pandas 1.4.0 breaks Yahoo Finance library #133

merged 1 commit into from
Jan 24, 2022

Conversation

manoelmarques
Copy link
Contributor

@manoelmarques manoelmarques commented Jan 24, 2022 •
edited
Loading

Summary

Pandas 1.4.0 released on 01/22/2022 breaks Yahoo Finance library.
Pinning pandas < 1.4.0 until Yahoo Finance library gets fixed.

Details and comments

@manoelmarques manoelmarques added type: bug Something isn't working priority: high labels Jan 24, 2022
@manoelmarques manoelmarques self-assigned this Jan 24, 2022
@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jan 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1737901189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 82.735%
Files with Coverage Reduction New Missed Lines %
qiskit_finance/data_providers/exchange_data_provider.py 2 73.02%
qiskit_finance/data_providers/wikipedia_data_provider.py 4 73.08%
Totals Coverage Status
Change from base Build 1688778591: 0.5%
Covered Lines: 714
Relevant Lines: 863
💛 - Coveralls

@manoelmarques manoelmarques merged commit 80accab into qiskit-community:main Jan 24, 2022
@manoelmarques manoelmarques deleted the yfinance branch January 24, 2022 03:55
mergify bot pushed a commit that referenced this pull request Jan 24, 2022
@manoelmarques
Pandas 1.4.0 breaks yfinance (#133)
a3d775f 
(cherry picked from commit 80accab)
@mergify mergify bot mentioned this pull request Jan 24, 2022
Merged
mergify bot added a commit that referenced this pull request Jan 24, 2022
@mergify @manoelmarques
Pandas 1.4.0 breaks yfinance (#133) (#134)
25a722b 
(cherry picked from commit 80accab)

Co-authored-by: Manoel Marques <[email protected]>
@burgholzer burgholzer mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm is a code owner

@pbark pbark Awaiting requested review from pbark

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

Assignees

@manoelmarques manoelmarques

Labels
priority: high stable backport potential The bug might be minimal and/or import enough to be port to stable type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manoelmarques @coveralls