Drop pandas requirement restriction
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
requested review from
stefan-woerner,
pbark,
manoelmarques and
woodsp-ibm
as code owners
|
|
Pull Request Test Coverage Report for Build 2506429974
💛 - Coveralls |
manoelmarques
added
the
stable backport potential
manoelmarques
previously approved these changes
Jun 16, 2022
manoelmarques
approved these changes
Jun 16, 2022
woodsp-ibm
approved these changes
Jun 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
* drop pandas requirement restriction * Add release notes Co-authored-by: Manoel Marques <[email protected]> (cherry picked from commit 8e1753f)
mergify bot
added a commit
that referenced
this pull request
Jun 16, 2022
* drop pandas requirement restriction * Add release notes Co-authored-by: Manoel Marques <[email protected]> (cherry picked from commit 8e1753f) Co-authored-by: Lukas Burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It should be safe to drop the restriction on the
pandasdependency that was introduced because of #133 by using the most recent version ofyfinance.Details and comments
The bug that broke
yfinanceupon upgrading topandas>=1.4.0(see #133) has been fixed in the release of version0.1.70(see https://github.com/ranaroussi/yfinance/releases/tag/0.1.70 and the corresponding issue ranaroussi/yfinance#937). As such, it should be safe to drop the restriction and permit newer versions of pandas.