Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] add info.json of Sparrow62 #11740

Merged
merged 2 commits into from
Feb 6, 2021
Merged

[Keyboard] add info.json of Sparrow62 #11740

merged 2 commits into from
Feb 6, 2021

Conversation

74th
Copy link

@74th 74th commented Jan 31, 2021

Description

I added info.json of Sparrow62 keyboard to use QMK Configurator.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@74th 74th changed the title add info.json of Sparrow62 [keyboard] add info.json of Sparrow62 Jan 31, 2021
@74th 74th changed the title [keyboard] add info.json of Sparrow62 [Keyboard] add info.json of Sparrow62 Jan 31, 2021
@drashna drashna requested a review from a team February 5, 2021 04:43
keyboards/sparrow62/info.json Outdated Show resolved Hide resolved
keyboards/sparrow62/info.json Outdated Show resolved Hide resolved
fix space, enter and align x

Co-authored-by: James Young <[email protected]>
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

image

@noroadsleft noroadsleft merged commit 31675c6 into qmk:master Feb 6, 2021
pull bot pushed a commit to kruton/qmk_firmware that referenced this pull request Feb 6, 2021
* add info.json for QMK Configurator

* Apply suggestions from code review

fix space, enter and align x
jordanlewis added a commit to jordanlewis/qmk_firmware that referenced this pull request Feb 8, 2021
* upstream/master: (723 commits)
  [Keyboard] Add The Stick keyboard (qmk#11745)
  [Docs] Update isp_flashing_guide.md (qmk#11777)
  [Keymap] Update keymap for keebio/nyquist (qmk#11734)
  [Keymap] Shadyproject/bfo9000 (qmk#11753)
  [Keymap] Update community ortholinear 4x12 keymap: junonum (qmk#11757)
  [Keyboard] Add my keymap for Mark65 (qmk#11717)
  [Keyboard] Add nknl7jp keyboard (qmk#11591)
  [Keyboard] Add nknl7en keyboard (qmk#11590)
  [Keyboard] Add ergoarrows keyboard (qmk#11592)
  [Keyboard] Add Hi-Tek AIM-65 keyboard (qmk#11623)
  [Keyboard] Add earth_rover keyboard (qmk#11405)
  [Keyboard] Whale 75 (qmk#11486)
  [Keyboard] VIA fix firmware sizes (qmk#11770)
  Fixed pin assignment on KBD8X Hotswap by Lucid (qmk#11807)
  Manual formatting fix for serial_uart.c (qmk#11806)
  [CI] Auto Formatting - Swap from direct commit to PR (qmk#11229)
  [Keyboard] add info.json of Sparrow62 (qmk#11740)
  Serial refactor (qmk#11521)
  update lck75 json file (qmk#11798)
  Manually run formatting job (qmk#11797)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
* add info.json for QMK Configurator

* Apply suggestions from code review

fix space, enter and align x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants