update lck75 json file #11798
Merged
update lck75 json file #11798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Feb 5, 2021
an error was made
found an extra key in the kle raw data
|
I didn't mean to remove the review request from other collaborators. my bad |
drashna
approved these changes
Feb 5, 2021
That's GitHub, not you. No worries. |
|
however, could you fix this: |
changed the product id to 0x6163, hopefully, it's valid. |
zvecr
requested changes
Feb 5, 2021
understood Co-authored-by: Joel Challis <[email protected]>
zvecr
approved these changes
Feb 5, 2021
|
Thanks! |
pull bot
pushed a commit
to kruton/qmk_firmware
that referenced
this pull request
Feb 5, 2021
* update lck75 json * Create info.json * wrong json file extension * updated layout height and width in json * Update info.json * reverted changes from last update to json an error was made * Update info.json found an extra key in the kle raw data * Changed product ID * Update keyboards/lck75/info.json understood Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
djuggler
added a commit
to djuggler/qmk_firmware
that referenced
this pull request
Feb 5, 2021
* 'master' of https://github.com/qmk/qmk_firmware: Serial refactor (qmk#11521) update lck75 json file (qmk#11798) Manually run formatting job (qmk#11797) [Keyboard] add shk9 macropad (qmk#11505) Fix build errors on kikoslab/kl90 default keymap (qmk#11796) [Keyboard] Fix the LED's ID of ISSI for MJ64 REV2 (qmk#11760) [Keyboard] Add VIA support to v60 Type R (qmk#11758) [Keyboard] add latin17rgb (qmk#11680)
jordanlewis
added a commit
to jordanlewis/qmk_firmware
that referenced
this pull request
Feb 8, 2021
* upstream/master: (723 commits) [Keyboard] Add The Stick keyboard (qmk#11745) [Docs] Update isp_flashing_guide.md (qmk#11777) [Keymap] Update keymap for keebio/nyquist (qmk#11734) [Keymap] Shadyproject/bfo9000 (qmk#11753) [Keymap] Update community ortholinear 4x12 keymap: junonum (qmk#11757) [Keyboard] Add my keymap for Mark65 (qmk#11717) [Keyboard] Add nknl7jp keyboard (qmk#11591) [Keyboard] Add nknl7en keyboard (qmk#11590) [Keyboard] Add ergoarrows keyboard (qmk#11592) [Keyboard] Add Hi-Tek AIM-65 keyboard (qmk#11623) [Keyboard] Add earth_rover keyboard (qmk#11405) [Keyboard] Whale 75 (qmk#11486) [Keyboard] VIA fix firmware sizes (qmk#11770) Fixed pin assignment on KBD8X Hotswap by Lucid (qmk#11807) Manual formatting fix for serial_uart.c (qmk#11806) [CI] Auto Formatting - Swap from direct commit to PR (qmk#11229) [Keyboard] add info.json of Sparrow62 (qmk#11740) Serial refactor (qmk#11521) update lck75 json file (qmk#11798) Manually run formatting job (qmk#11797) ...
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Feb 10, 2021
* update lck75 json * Create info.json * wrong json file extension * updated layout height and width in json * Update info.json * reverted changes from last update to json an error was made * Update info.json found an extra key in the kle raw data * Changed product ID * Update keyboards/lck75/info.json understood Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
found that the json did not display the layout correctly on the configurator web app
Types of Changes
edited and fixed the lck json file to correctly reference the layouts used by the board
Issues Fixed or Closed by This PR
fixes the layout display of the lck75 on the configurator web app
*
Checklist