Clean up includes for glcdfont headers #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also tagging @tominabox1 |
|
@fauxpark Everything seems okay here on my keymap with this change. 👍 |
tominabox1
previously approved these changes
Dec 31, 2019
drashna
previously approved these changes
Jan 2, 2020
Curry
added a commit
to Curry/qmk_firmware
that referenced
this pull request
Jan 9, 2020
drashna
pushed a commit
that referenced
this pull request
Jan 9, 2020
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from #7745 * Modify Keymaps, add workman * RGB & OLED update
|
@MakotoKurauchi and @soundmonster, would you mind adding your approvals to this PR? Thanks :) |
ridingqwerty
previously approved these changes
Feb 13, 2020
MakotoKurauchi
previously approved these changes
Feb 13, 2020
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
fauxpark
dismissed stale reviews from soundmonster, MakotoKurauchi, ridingqwerty, and kidBrazil
via
b8c29d3
drashna
approved these changes
Mar 1, 2020
cmaier
pushed a commit
to cmaier/qmk_firmware
that referenced
this pull request
Mar 1, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
rhruiz
pushed a commit
to rhruiz/qmk_firmware
that referenced
this pull request
Mar 1, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Mar 3, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (37 commits) Update Hungarian keymap and add sendstring LUT (qmk#8220) Remove "ugly hack in usb_main.c" comments (qmk#8296) Update encoder functions for Iris VIA keymap (qmk#8295) Reduce PROGMEM usage for sendstring LUT (qmk#8109) [Docs] Update ISP Flashing guide (qmk#8149) Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243) Add onekey keymap for testing reset to bootloader. (qmk#8288) Get the direction right on the S75 encoder (qmk#8287) Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041) Make a fix to savage65 and tmov2 for via (qmk#8286) format code according to conventions [skip ci] Short term fix for conflicting types for 'tfp_printf' (qmk#8157) Fix recent clang-format breaking quantum.c (qmk#8282) format code according to conventions [skip ci] Remove duplicate BRTG case (qmk#8277) Clean up includes for glcdfont headers (qmk#7745) Fix the Breaking Changes doc again [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137) PWM DMA based RGB Underglow for STM32 (qmk#7928) Add VIA support to Prime_M. Clean up all files (qmk#8247) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Mar 5, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Apr 2, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
14 tasks
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Clean up includes for glcdfont headers * Remove pragma once, most of these are not headers * Missed these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tmk_core/progmem.hdoes much the same as this preprocessor code. I don't see where ESP8266 is defined, or supported, so I'm assuming this is just copypasta and we can ignore it.Tagging the following for approval, as this touches your keymaps (but should not change anything behaviourally):
@drashna ✅
@kidBrazil ✅
@MakotoKurauchi ✅
@rpbaptist ✅
@soundmonster ✅
@tominabox1 ✅
Types of Changes
Issues Fixed or Closed by This PR
Checklist