translated 'feature_tap_dance.md' to japanese. #8137

s-show · 2020-02-10T15:31:33Z

Description

Update Japanese translation.

Types of Changes

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ridingqwerty

I made some suggestions regarding a numbered list that had all elements as one, and another regarding some code comments that retained their English translation -- which may be desired.

As far as the translation itself, I am not a speaker of Japanese so I only ran chunks through google translate and what I skimmed there seemed sound. So this gets an __attribute__((weak)) approval from me pending the correction of the list I pointed out.

docs/ja/feature_tap_dance.md

Update the file based on the suggestions. Co-Authored-By: shela <[email protected]>

docs/ja/feature_tap_dance.md

Update the file based on the suggestions (Part 2). Co-Authored-By: shela <[email protected]>

Update the file based on the suggestions (Part 3). Co-Authored-By: shela <[email protected]>

docs/ja/feature_tap_dance.md

Update the file based on the suggestions (Part 4). Co-Authored-By: shela <[email protected]>

Update the file based on the suggestions (Part 5). ご提案いただいた修正案は全て確認できました。続いて、コメント行の調整、「打つ・叩く」の変更、その他の修正を行います。 Co-Authored-By: shela <[email protected]>

shelaf

I will approve when this fix is done.
@mtei I want you to check if you have time.

docs/ja/feature_tap_dance.md

mtei

特に問題はなさそうでした。イントロダクションのコメントはお好みで採用でも不採用でも構いません。

Looks Good To Me.

docs/ja/feature_tap_dance.md

Update the file based on the suggestions (Part 8). Co-Authored-By: Takeshi ISHII <[email protected]>

docs/ja/feature_tap_dance.md

mtei

Looks Good To Me !

noroadsleft · 2020-03-01T04:24:27Z

ありがとうございました！

* complete translation. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions. * Apply suggestions from code review Update the file based on the suggestions. * Apply suggestions from code review Update the file based on the suggestions (Part 2). * Apply suggestions from code review Update the file based on the suggestions (Part 3). * Apply suggestions from code review Update the file based on the suggestions (Part 3). * Apply suggestions from code review Update the file based on the suggestions (Part 4). * Apply suggestions from code review Update the file based on the suggestions (Part 5). ご提案いただいた修正案は全て確認できました。続いて、コメント行の調整、「打つ・叩く」の変更、その他の修正を行います。 * fixed typo. * Update the file based on the suggestions (Part 6). * Update the file based on the suggestions (Part 7). * Fixed sentence. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions (Part 8). * Update the file based on the suggestions (Part 9). Co-Authored-By: Takeshi ISHII <[email protected]> Co-Authored-By: shela <[email protected]>

* 'master' of https://github.com/qmk/qmk_firmware: (37 commits) Update Hungarian keymap and add sendstring LUT (qmk#8220) Remove "ugly hack in usb_main.c" comments (qmk#8296) Update encoder functions for Iris VIA keymap (qmk#8295) Reduce PROGMEM usage for sendstring LUT (qmk#8109) [Docs] Update ISP Flashing guide (qmk#8149) Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243) Add onekey keymap for testing reset to bootloader. (qmk#8288) Get the direction right on the S75 encoder (qmk#8287) Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041) Make a fix to savage65 and tmov2 for via (qmk#8286) format code according to conventions [skip ci] Short term fix for conflicting types for 'tfp_printf' (qmk#8157) Fix recent clang-format breaking quantum.c (qmk#8282) format code according to conventions [skip ci] Remove duplicate BRTG case (qmk#8277) Clean up includes for glcdfont headers (qmk#7745) Fix the Breaking Changes doc again [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137) PWM DMA based RGB Underglow for STM32 (qmk#7928) Add VIA support to Prime_M. Clean up all files (qmk#8247) ...

* complete translation. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions. * Apply suggestions from code review Update the file based on the suggestions. * Apply suggestions from code review Update the file based on the suggestions (Part 2). * Apply suggestions from code review Update the file based on the suggestions (Part 3). * Apply suggestions from code review Update the file based on the suggestions (Part 3). * Apply suggestions from code review Update the file based on the suggestions (Part 4). * Apply suggestions from code review Update the file based on the suggestions (Part 5). ご提案いただいた修正案は全て確認できました。続いて、コメント行の調整、「打つ・叩く」の変更、その他の修正を行います。 * fixed typo. * Update the file based on the suggestions (Part 6). * Update the file based on the suggestions (Part 7). * Fixed sentence. * Update docs/ja/feature_tap_dance.md Update the file based on the suggestions (Part 8). * Update the file based on the suggestions (Part 9). Co-Authored-By: Takeshi ISHII <[email protected]> Co-Authored-By: shela <[email protected]>

complete translation.

bbf7da9

s-show changed the title ~~complete translation.~~ translated 'feature_tap_dance.md' to japanese. Feb 10, 2020

ridingqwerty requested changes Feb 10, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

ridingqwerty added documentation translation labels Feb 10, 2020

shelaf reviewed Feb 11, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

ridingqwerty approved these changes Feb 11, 2020

View reviewed changes

shelaf reviewed Feb 11, 2020

View reviewed changes

s-show and others added 3 commits February 11, 2020 22:54

Update docs/ja/feature_tap_dance.md

d72801d

Update the file based on the suggestions. Co-Authored-By: shela <[email protected]>

Update docs/ja/feature_tap_dance.md

7e08de2

Update the file based on the suggestions. Co-Authored-By: shela <[email protected]>

Apply suggestions from code review

ffd8782

Update the file based on the suggestions. Co-Authored-By: shela <[email protected]>

shelaf reviewed Feb 12, 2020

View reviewed changes

s-show and others added 3 commits February 12, 2020 23:52

Apply suggestions from code review

ef515ac

Update the file based on the suggestions (Part 2). Co-Authored-By: shela <[email protected]>

Apply suggestions from code review

4312de6

Update the file based on the suggestions (Part 3). Co-Authored-By: shela <[email protected]>

Apply suggestions from code review

b5c096b

Update the file based on the suggestions (Part 3). Co-Authored-By: shela <[email protected]>

shelaf reviewed Feb 18, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

s-show and others added 5 commits February 20, 2020 00:06

Apply suggestions from code review

6d59ba0

Update the file based on the suggestions (Part 4). Co-Authored-By: shela <[email protected]>

fixed typo.

b42fad7

Merge branch 'temp' into tapdance_docs_translate_japanese

7216130

Update the file based on the suggestions (Part 6).

e6a450d

shelaf suggested changes Feb 25, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

Update the file based on the suggestions (Part 7).

88af69d

shelaf suggested changes Feb 25, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

Fixed sentence.

b98411c

shelaf approved these changes Feb 26, 2020

View reviewed changes

mtei approved these changes Feb 26, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

Update docs/ja/feature_tap_dance.md

9790f31

Update the file based on the suggestions (Part 8). Co-Authored-By: Takeshi ISHII <[email protected]>

mtei reviewed Feb 26, 2020

View reviewed changes

docs/ja/feature_tap_dance.md Outdated Show resolved Hide resolved

s-show added 2 commits February 27, 2020 22:06

Update the file based on the suggestions (Part 9).

598e85b

Merge branch 'temp' into tapdance_docs_translate_japanese

2218573

mtei approved these changes Feb 27, 2020

View reviewed changes

noroadsleft added ready to merge and removed ready to merge labels Feb 29, 2020

noroadsleft merged commit 2171521 into qmk:master Mar 1, 2020

s-show deleted the tapdance_docs_translate_japanese branch March 1, 2020 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

translated 'feature_tap_dance.md' to japanese. #8137

translated 'feature_tap_dance.md' to japanese. #8137

s-show commented Feb 10, 2020

ridingqwerty left a comment

shelaf left a comment

mtei left a comment

mtei left a comment

noroadsleft commented Mar 1, 2020

translated 'feature_tap_dance.md' to japanese. #8137

translated 'feature_tap_dance.md' to japanese. #8137

Conversation

s-show commented Feb 10, 2020

Description

Types of Changes

Checklist

ridingqwerty left a comment

Choose a reason for hiding this comment

shelaf left a comment

Choose a reason for hiding this comment

mtei left a comment

Choose a reason for hiding this comment

mtei left a comment

Choose a reason for hiding this comment

noroadsleft commented Mar 1, 2020