Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 121 #124

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Revert PR 121 #124

merged 1 commit into from
Jun 21, 2023

Conversation

majguo
Copy link
Contributor

@majguo majguo commented Jun 21, 2023

After merging #121, I observed a warning message when running the sample app integration-tests/azure-storage-blob as a native exectuable:

You're already on a Vert.x context, are you sure you want to create a new Vertx instance?

After looking around, the warning message is most probably due to calling Vertx.vertx() in com.azure:azure-core-http-vertx. More details pls see vert-x3/vertx-web#1117.

So the PR is to revert #121 to get rid of the warning message, which is verified locally.

…red by azure-core-http-vertx"

This reverts commit 8111316.
@majguo majguo temporarily deployed to ci June 21, 2023 06:16 — with GitHub Actions Inactive
@majguo majguo merged commit fceb5a1 into quarkiverse:main Jun 21, 2023
@majguo majguo deleted the revert-pr-121 branch June 21, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant