Make kotlin not load parent first, and stop handling pact parent-first configuration in core quarkus #30230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reinstate @stuartwdouglas's changes from #29697. They’re breaking changes, so they were reverted, but it’s appropriate to apply them in a 3.0 branch.
This PR also has some changes of mine. We always felt a bit uncomfortable having lots of pact configuration in quarkus core, and now that we have a pact extension we can move that config to a more targeted place.
Note that the changes in #29697 break the pact extension. The second set changes in this PR are mine. They half-fix the pact support, but they also need https://github.com/holly-cummins/quarkus-pact/tree/pact-for-quarkus-3 to be applied to the pact extension for things to work fully properly.
When @gsmet is doing the patch-y sync-y magic, could we please
Why so convoluted? The
extensions/kotlin/runtime/pom.xml
had some changes made, and then reverted, and this changeset reinstates them. But the original change is in the branch I’m basing this change against, and the reversion isn’t. I’ve cherry-picked the reversion in to this branch, and then reverted the reversion … confused yet? My assumption is that git could also get confused by all this, so we should check the output by eye.At the end, the maven plugin config in the kotlin
pom.xml
should be something like this (no parent-first artefacts):For background, these are the relevant changes in the history.
https://github.com/quarkusio/quarkus/pull/29697/commits (in the branch)
https://github.com/quarkusio/quarkus/pull/29869/commits (not in the branch)