Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kotlin not load parent first, and stop handling pact parent-first configuration in core quarkus #30230

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Make kotlin not load parent first, and stop handling pact parent-first configuration in core quarkus #30230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f77fa9
Re-apply (breaking) change to not load kotlin parent first
holly-cummins Jan 6, 2023
23b12b6
Move parent-first loading of Pact to the Pact extension (and it's mos…
holly-cummins Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions core/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,26 +194,6 @@
<parentFirstArtifact>org.opentest4j:opentest4j</parentFirstArtifact>
<parentFirstArtifact>org.junit.platform:junit-platform-commons</parentFirstArtifact>

<!-- Pact[<4.1.0] support. It would be great if there was somewhere better to put this-->
<parentFirstArtifact>au.com.dius:pact-jvm-provider-junit5</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-provider</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-core-support</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-core-pact-broker</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-core-model</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-core-matchers</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-junit5</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-consumer-java8</parentFirstArtifact>
<parentFirstArtifact>au.com.dius:pact-jvm-consumer</parentFirstArtifact>
<!-- Pact[>=4.1.0] support.-->
<parentFirstArtifact>au.com.dius.pact.provider:junit5</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact:provider</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact.core:support</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact.core:pactbroker</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact.core:model</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact.core:matcher</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact.consumer:junit5</parentFirstArtifact>
<parentFirstArtifact>au.com.dius.pact:consumer</parentFirstArtifact>

<!-- Make use of byteman frictionless -->
<parentFirstArtifact>org.jboss.byteman:byteman</parentFirstArtifact>
</parentFirstArtifacts>
Expand Down
16 changes: 0 additions & 16 deletions extensions/kotlin/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,6 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-maven-plugin</artifactId>
<configuration>
<parentFirstArtifacts>
<parentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-jdk8</parentFirstArtifact>
<parentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-jdk7</parentFirstArtifact>
<parentFirstArtifact>org.jetbrains.kotlin:kotlin-reflect</parentFirstArtifact>
<parentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib</parentFirstArtifact>
<parentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-common</parentFirstArtifact>
<parentFirstArtifact>org.jetbrains:annotations</parentFirstArtifact>
</parentFirstArtifacts>
<runnerParentFirstArtifacts>
<runnerParentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-jdk8</runnerParentFirstArtifact>
<runnerParentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-jdk7</runnerParentFirstArtifact>
<runnerParentFirstArtifact>org.jetbrains.kotlin:kotlin-reflect</runnerParentFirstArtifact>
<runnerParentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib</runnerParentFirstArtifact>
<runnerParentFirstArtifact>org.jetbrains.kotlin:kotlin-stdlib-common</runnerParentFirstArtifact>
<runnerParentFirstArtifact>org.jetbrains:annotations</runnerParentFirstArtifact>
</runnerParentFirstArtifacts>
<lesserPriorityArtifacts>
<!--
see https://github.com/quarkusio/quarkus/issues/8405
Expand Down