Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: pretty_name introduces changed names and some are missing #1099

Closed
philclifford opened this issue Apr 21, 2024 · 5 comments · Fixed by #1101
Closed

bug: pretty_name introduces changed names and some are missing #1099

philclifford opened this issue Apr 21, 2024 · 5 comments · Fixed by #1101
Labels
bug Something isn't working

Comments

@philclifford
Copy link
Contributor

Some changes in a draft README.md update arise from cog : presumably the revised approach to pretty_name needs some additional data or a tweak

Originally posted by @philclifford in #1098 (comment)
@flexiondotorg
Copy link
Member

Gnome OS and Tuxedo OS are missing pretty names and the pretty name for CrunchBang is ugly 😄

@flexiondotorg flexiondotorg changed the title pretty_name introduces changed names and some are missing bug: pretty_name introduces changed names and some are missing Apr 21, 2024
@flexiondotorg flexiondotorg added the bug Something isn't working label Apr 21, 2024
@flexiondotorg flexiondotorg moved this to Todo in quickemu 4.9.3 Apr 21, 2024
@philclifford philclifford mentioned this issue Apr 21, 2024
Merged
@philclifford
Copy link
Contributor Author

To fix/confirm:

  • athenaos (Athena Os)
  • bazzite (bazzite) -> Bazzite (they use both all over so lets be self-consistent
  • biglinux (Big Linux) -> BigLinux
  • bunsenlabs (Bunsenlab) -> BunsenLabs
  • crunchbang++ (#!++)
  • gnomeos () : missing entry in os_info. Q: should it even be supported yet ?
  • primtux (PrimTux) : Ok, but out of order
  • slitaz (SliTaz)
  • spirallinux (Spiral Linux)
  • tuxedo-os () : was missing a line

@philclifford philclifford moved this from Todo to In Progress in quickemu 4.9.3 Apr 22, 2024
@philclifford
Copy link
Contributor Author

Gnome OS and Tuxedo OS are missing pretty names and the pretty name for CrunchBang is ugly 😄

The first two are sorted in the PR which now incorporates the consequent documentation changes. I agree that crunchbang++ has an UglyName, but it's what they call it... If it changes in quickget a doc regen will follow .

@philclifford philclifford moved this from In Progress to Done in quickemu 4.9.3 Apr 22, 2024
@zen0bit
Copy link
Contributor

zen0bit commented Apr 22, 2024

I thought abou leaving ++ from normal name but looks don't do any trouble...

@zen0bit
Copy link
Contributor

zen0bit commented Apr 22, 2024 •
edited
Loading

Can you also add these ' - ' to empty credentials info?

And tuxeso-os > tuxedoos

PS: Spotted I used Independent you Independant = Choose the right one (not native english speaker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
quickemu 4.9.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: tweaks for os_info() philclifford/quickemu
3 participants
@flexiondotorg @zen0bit @philclifford