Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New UI #999

Merged
merged 48 commits into from
Apr 21, 2024
Merged

feat: New UI #999

merged 48 commits into from
Apr 21, 2024

Conversation

zen0bit
Copy link
Contributor

@zen0bit zen0bit commented Apr 12, 2024

PR: Add new run script

Otherwise mostly fixes whats already in repo,
not yet working, or was broken by latest changes.
(by me 😃)

Brief summary of PR content

Style:

  • Style improvements
  • Indentation fixes
  • Tabs changed to spaces
  • Function sorted by alphabet
  • Slightly modified some message to user
  • Make code style in whole script mostly same
  • Added help message

Changes:

  • Reworked os_info functions now using get_opts.
  • Reworked arguments
  • More use of cut_1 function

Added:

  • Added new run script
  • (re)Added new error functions
  • Introduced just variable

Removing:

  • Whole quickget script bit cleaned
  • Cleanup

For full changelog please look in commits.
I tried made them as simply as posible 🤝

Most of things should work as expected now
(Not everything yet!)

!bugs expected! Not finished!

Since this is only branch I am considering this branch as DEV

⭐ But good to go ⭐

@zen0bit zen0bit force-pushed the almost_final branch 5 times, most recently from 2ef58e4 to bb4da96 Compare April 13, 2024 00:34
@zen0bit
Copy link
Contributor Author

zen0bit commented Apr 13, 2024

Look into details of tests...

@zen0bit zen0bit force-pushed the almost_final branch 4 times, most recently from 45854b1 to 442438e Compare April 13, 2024 01:19
@zen0bit
Copy link
Contributor Author

zen0bit commented Apr 13, 2024

quickget-test workflow file LGTM

@zen0bit
Copy link
Contributor Author

zen0bit commented Apr 13, 2024

lets repair all ubuntu derivatives test in quickget...

@zen0bit zen0bit force-pushed the almost_final branch 3 times, most recently from c8a6b97 to 3d134b2 Compare April 13, 2024 15:25
@TuxVinyards
Copy link
Contributor

      pureos)         INFO="PureOS|Debian||https://www.pureos.net/|A fully free/libre and open source GNU/Linux operating system, endorsed by the Free Software Foundation.";;

      tuxedo-os)         INFO="Tuxedo OS|Ubuntu||https://www.tuxedocomputers.com/en/|KDE Ubuntu LTS designed to go with their Linux hardware.";;

@zen0bit A couple of lines for you to paste in

@zen0bit zen0bit force-pushed the almost_final branch 4 times, most recently from 0abdfc8 to 60f98a4 Compare April 14, 2024 00:22
@zen0bit zen0bit changed the title Almost final 🏗️ Almost final Apr 14, 2024
@zen0bit zen0bit changed the title 🏗️ Almost final 🏗️ Almost final ⏳ Apr 14, 2024
@zen0bit zen0bit changed the title 🏗️ Almost final ⏳ 🏗️ Almost final ⏳ - TEST it Apr 14, 2024
@zen0bit zen0bit force-pushed the almost_final branch 5 times, most recently from 4296b24 to a747d58 Compare April 14, 2024 04:44
@zen0bit
Copy link
Contributor Author

zen0bit commented Apr 21, 2024

I hate rebasing

Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./quickget --url-all debian and ./quickget --check-all debian both prompt for release and edition when executed, but according to the help they should work.

@flexiondotorg
Copy link
Member

I hate rebasing

Sorry ❤️ We're nearly in sync and harmony is close by 🙂

@zen0bit
Copy link
Contributor Author

zen0bit commented Apr 21, 2024

./quickget --url-all debian and ./quickget --check-all debian both prompt for release and edition when executed, but according to the help they should work.

Not yet remade to work with OS only

(Maybe because I have to do only rebasing instead of focus on work itself)

@flexiondotorg
Copy link
Member

Not yet remade to work with OS only

Understood. So, these options do not quite work as intended at the moment but can be updated in a future pull request.

Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

  • Some recent changes are missing, but I'll add them back via another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants