Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tweaks for os_info() #1101

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Conversation

philclifford
Copy link
Contributor

@philclifford philclifford commented Apr 21, 2024

Closes #1099
Closes #1098
Closes #1095

reviewed changed and missing names. Some confirmed but some descriptions were re-aligned with the distros and a couple of missing lines added. Also re-ordered one.

Documentation changes in de20064 include both the effects of these fixes and the wiki links and changes in the draft #1098

@philclifford philclifford marked this pull request as ready for review April 21, 2024 23:53
NB This also includes documentation changes linking to the wiki that identified these possible issues
quickget Outdated Show resolved Hide resolved
Copy link
Contributor

@zen0bit zen0bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remade my grammar flaw of Independent

Or you missed the right world?
'Independant'

quickget Outdated Show resolved Hide resolved
@zen0bit
Copy link
Contributor

zen0bit commented Apr 22, 2024

Added all to my fill PR...

@zen0bit
Copy link
Contributor

zen0bit commented Apr 22, 2024

tuxedoos in #1103
And then good to go..

Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the tuxedo fix from #1103

Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to merge this as is and then work on merging @zen0bit work from #1097

@flexiondotorg flexiondotorg merged commit 5f6495c into quickemu-project:master Apr 23, 2024
@philclifford philclifford deleted the fix-1099 branch April 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: pretty_name introduces changed names and some are missing
3 participants