-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ds-390 remove pause, restart scans #350
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 84.19% 84.32% +0.13%
==========================================
Files 116 116
Lines 3783 3765 -18
Branches 1345 1343 -2
==========================================
- Hits 3185 3175 -10
+ Misses 537 530 -7
+ Partials 61 60 -1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I started (but never finished) a change like this a couple weeks ago too, and your change looks a lot like mine but even more comprehensive. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's included
Notes
the icons contain a "restart" icon that displays forstart
in the event a user has a failed scan. we can replace this if needed with just the "play" icon, see attached screenshotplay
andstop
see the attached screenshotHow to test
Coverage and basic unit test check
$ yarn
$ yarn test
Local run check
$ yarn
$ yarn start:stage
*note: the icons contain a "restart" icon that displays forstart
in the event a user has a failed scan*note: the only remaining icons are now
play
andstop
cancel
/stop
start
/play
Check the build
$ yarn
$ yarn build
Example
Updates issue/story
DISCOVERY-390
blocked by #345 #346 #347 #349