Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ds-390 remove pause, restart scans #350

Merged
merged 2 commits into from
May 7, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 26, 2024

What's included

  • refactor: ds-390 remove pause, restart scans

Notes

  • removes v1s pause, restart scans functionality
  • the icons contain a "restart" icon that displays for start in the event a user has a failed scan. we can replace this if needed with just the "play" icon, see attached screenshot
    • the only remaining icons are play and stop see the attached screenshot

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. confirm the functionality that remains for scans is for
    *note: the icons contain a "restart" icon that displays for start in the event a user has a failed scan
    *note: the only remaining icons are now play and stop
    • cancel/stop
    • start/play

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

Screenshot 2024-05-06 at 2 12 56 PM

Updates issue/story

DISCOVERY-390
blocked by #345 #346 #347 #349

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.32%. Comparing base (3d66168) to head (108df8c).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   84.19%   84.32%   +0.13%     
==========================================
  Files         116      116              
  Lines        3783     3765      -18     
  Branches     1345     1343       -2     
==========================================
- Hits         3185     3175      -10     
+ Misses        537      530       -7     
+ Partials       61       60       -1     
Files Coverage Δ
src/components/contextIcon/contextIconAction.js 100.00% <100.00%> (ø)
src/components/scans/scans.js 81.08% <100.00%> (+3.58%) ⬆️
src/components/scans/scansContext.js 72.79% <ø> (+3.19%) ⬆️
src/redux/actions/scansActions.js 100.00% <ø> (ø)
src/redux/constants/scansConstants.js 100.00% <ø> (ø)
src/redux/reducers/scansReducer.js 100.00% <ø> (ø)
src/services/scansService.js 100.00% <ø> (ø)
src/components/scans/scansTableCells.js 74.22% <0.00%> (+3.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8815d1...108df8c. Read the comment docs.

cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 2, 2024
cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 2, 2024
@cdcabrera cdcabrera removed the blocked label May 6, 2024
cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 6, 2024
cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 6, 2024
@cdcabrera cdcabrera changed the title WIP, refactor: ds-390 remove pause, restart scans refactor: ds-390 remove pause, restart scans May 6, 2024
@cdcabrera cdcabrera marked this pull request as ready for review May 6, 2024 17:36
cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 6, 2024
cdcabrera added a commit to cdcabrera/quipucords-ui that referenced this pull request May 6, 2024
Copy link
Member

@infinitewarp infinitewarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I started (but never finished) a change like this a couple weeks ago too, and your change looks a lot like mine but even more comprehensive. Thanks!

Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdcabrera cdcabrera merged commit d040f9a into quipucords:main May 7, 2024
3 of 5 checks passed
cdcabrera added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants