Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scans): ds-98 disable expandable sources #365

Merged
merged 1 commit into from
May 7, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 6, 2024

What's included

  • fix(scans): ds-98 disable expandable sources

Notes

  • the sources displayed under scans suffers from an sequential id issue, this bypasses the issue by disabling the expansion field
    • we discussed using the same display v2 uses but until it can be determined v2 is pulling the correct information we're taking the direct approach of disabling the field all together
      • the number of sources that are displayed is an aspect of what v2 uses to show sources
  • we deprecated the old "scanSourceList.js" component as opposed to deleting it simply because it was faster to type the word vs deleting the file, test file, test snapshots, etc. if someone wants us to remove it entirely we can also do that

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. confirm that the sources displayed on scans is now disabled, no longer clickable

Example

Screenshot 2024-05-06 at 2 31 05 PM

Updates issue/story

DISCOVERY-98
blocked by, requires #350

@cdcabrera cdcabrera added bug Something isn't working blocked labels May 6, 2024
@cdcabrera cdcabrera changed the title WIP fix(scans): ds-98 disable expandable sources fix(scans): ds-98 disable expandable sources May 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.31%. Comparing base (3d66168) to head (dca5c6c).
Report is 20 commits behind head on main.

❗ Current head dca5c6c differs from pull request most recent head 97f4f2d. Consider uploading reports for the commit 97f4f2d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   84.19%   84.31%   +0.12%     
==========================================
  Files         116      116              
  Lines        3783     3761      -22     
  Branches     1345     1341       -4     
==========================================
- Hits         3185     3171      -14     
+ Misses        537      530       -7     
+ Partials       61       60       -1     
Files Coverage Δ
src/components/contextIcon/contextIconAction.js 100.00% <100.00%> (ø)
src/components/scans/scanSourceList.js 84.00% <ø> (ø)
src/components/scans/scans.js 81.08% <100.00%> (+3.58%) ⬆️
src/components/scans/scansContext.js 72.79% <ø> (+3.19%) ⬆️
src/redux/actions/scansActions.js 100.00% <ø> (ø)
src/redux/constants/scansConstants.js 100.00% <ø> (ø)
src/redux/reducers/scansReducer.js 100.00% <ø> (ø)
src/services/scansService.js 100.00% <ø> (ø)
src/components/scans/scansTableCells.js 73.11% <50.00%> (+1.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d040f9a...97f4f2d. Read the comment docs.

@cdcabrera cdcabrera removed the blocked label May 7, 2024
@cdcabrera cdcabrera marked this pull request as ready for review May 7, 2024 17:36
Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdcabrera cdcabrera merged commit f9f0305 into quipucords:main May 7, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants