refactor(i18n): ds-742 component, test updates #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
ds-742-i18n
branch
from
af8c89e
to
2f46e48
Compare
nicolearagao
approved these changes
Sep 9, 2024
* app, clean unused not-so-dynamic locale prop * i18n, remove min used helper, add test * index, remove strictMode, interferes in i18next loading * sessionProvider, removed since only used locale Relates to JIRA: DISCOVERY-742
cdcabrera
force-pushed
the
ds-742-i18n
branch
from
2f46e48
to
bcafd0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Coverage and basic unit test check
$ npm install$ npm testLocal run check
$ npm install$ npm run startExample
...
Updates issue/story
DISCOVERY-742