Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ds-839 block modal form submissions #517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 14, 2024

What's included

  • fix: ds-839 block modal form submissions

Notes

  • leverages existing toast notification layout to aid in preventing modal closing after form submission
  • basic blocking for modal forms for
  • what this doesn't do
    • enhance the toast notification messages or perform inline form messaging.
    • give some level of loading indicator for the form submission

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start:stage
  3. confirm basic form submission for
    • Add/Edit sources is blocked with a toast notification
    • Adding a scan is blocked with a toast notification
    • Adding a credential is blocked with a toast notification

Example

expected basic toast notifications
Screenshot 2024-11-14 at 2 06 55 PM (2)
Screenshot 2024-11-14 at 2 06 39 PM (2)
Screenshot 2024-11-14 at 2 06 12 PM (2)

Updates issue/story

DISCOVERY-839

@cdcabrera cdcabrera marked this pull request as ready for review November 14, 2024 20:03
@cdcabrera cdcabrera requested review from nicolearagao and a team November 14, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant