Fix a couple of blunders #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasFella
previously approved these changes
Sep 1, 2024
Using a handcrafted condition is both longer and error-prone (see #793).
QAnyStringView (and any string view, in fact) cannot be used in invocations from QML - meaning that anything Q_INVOKABLE in these files cannot use string views.
KitsuneRal
force-pushed
the
kitsune/post-beta-fixes
branch
from
689a5e5
to
a80a6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a fix for the problem identified in #793; the second one fixes inability to work with
Quotient::Settingsand its kin from QML.